Fix deprecated datetime.utcfromtimestamp() calls#3410
Open
apoorvdarshan wants to merge 1 commit intospotify:masterfrom
Open
Fix deprecated datetime.utcfromtimestamp() calls#3410apoorvdarshan wants to merge 1 commit intospotify:masterfrom
apoorvdarshan wants to merge 1 commit intospotify:masterfrom
Conversation
Fixes spotify#3356 and spotify#3317. `datetime.utcfromtimestamp()` is deprecated since Python 3.12 and scheduled for removal. Replace with timezone-aware alternatives that preserve naive UTC datetime behavior for backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.utcfromtimestamp()convertstime.time()to wrong datetime value inluigi.tools.range.RangeBase#3317datetime.utcfromtimestamp()inluigi/parameter.pyandluigi/tools/range.pytzinfo=Nonestripping to preserve naive UTC datetime behavior for backwards compatibilityChanges
luigi/parameter.py: Replacedatetime.datetime.utcfromtimestamp(0)withdatetime.datetime(1970, 1, 1)— equivalent and avoids the deprecation entirelyluigi/tools/range.py: Replacedatetime.utcfromtimestamp(ts)withdatetime.fromtimestamp(ts, tz=timezone.utc).replace(tzinfo=None)— converts via UTC then strips tzinfo to keep naive datetime compatibilityTest plan